Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Task 2 completed #1

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Github Task 2 completed #1

merged 2 commits into from
Mar 1, 2024

Conversation

Hemu21
Copy link
Owner

@Hemu21 Hemu21 commented Mar 1, 2024

Github Task 2 Completed:

  • Add Image Feature for tutorials
  • Now Users can upload images while creating tutorials
  • upload images in tutorial creating issue is Fixed.

Description

I had changed the index file inside the new tutorial folder because we are uploading image while creating the tutorial has the issue. I added functionality to that image icon button so that it can able to accept the file as input and I had changed the tutorial actions file because we are saving the tutorials data to database from this file only.

Related Issue

Steps to Reproduce Issue:

  • Setup the project using main codebase from c2si repository.
  • Now login in the website hosted in your localhost.
  • Now go to tutorial page.
  • Click on the create new tutorial button. You see the popup for creating tutorial.
  • Now click on the image icon to insert image. The button is not working you are unable to add image while creating tutorial.

Motivation and Context

This change is necessary because of this issue user is unable to upload the image user want. We are provided the image icon to add the image but the adding image functionality is not given. This leads to bad user experience. By fixing this issue user can able to add the image that user want while creating the tutorial. This will increase the user experience.

How Has This Been Tested?

  • Setup the project.
  • Now login in the website hosted in your localhost.
  • Now go to tutorial page.
  • Click on the create new tutorial button. You see the popup for creating tutorial.
  • Now click on the image icon to insert image. The button is working now you are able to add image while creating tutorial.
  • Now go to tutorial page and click on the organization tab you can see that image is added there as shown in below video.

Screenshots or GIF (In case of UI changes):

Task_2_completed.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Hemu21 Hemu21 merged commit 698b509 into master Mar 1, 2024
@shivareddy6
Copy link

Heyy @Hemu21, we wanted you to solve these issues in your forked repositories so that you can maintain confidentiality of your approaches. If you use the issue link your pr, it gets displayed in the main thread of the issue as well. I would suggest you to remove the issue link from your pr.

@Hemu21
Copy link
Owner Author

Hemu21 commented Mar 3, 2024

Ok @shivareddy6 brother.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants