Issue/80 #98
Merged
Issue/80 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darbyjack
previously approved these changes
Jun 18, 2024
# Conflicts: # src/main/java/com/extendedclip/deluxemenus/action/ClickActionTask.java
darbyjack
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is built on top of #64. Please merge that one before merging this one.
When opening a menu with
/dm open <menu> [viewer] -p:<target>, the target should be used to parse all placeholders. This was the case for menu title, item name, item lore, item amount, action chance, action delay, and everywhere else except for actions.Closes #80
Tested on:
Tested menu title, item lore, item name, broadcast action:
