Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align all 3 DK specs rune definitions #4380

Open
wants to merge 2 commits into
base: thewarwithin
Choose a base branch
from
Open

Align all 3 DK specs rune definitions #4380

wants to merge 2 commits into from
+22 −30

Conversation

syrifgit
Copy link
Collaborator

@syrifgit syrifgit commented Feb 18, 2025 •
edited
Loading

  • Nil protections were missing from Frost and Unholy reset function
  • Update Blood expiry table stuff to match the newer version in UH/Frost
  • Changed formatting / declaration order of model to be identical between the 3, no functional change
  • Simplify some wordy comments, removed duplicated ones, whitespace stuff, etc.

@syrifgit
Align all 3 DK specs rune definitions
89a001e 
Nil protections were missing from Frost and Unholy. Changed formatting to be identical between the 3. Simplify some wordy comments.
@syrifgit
Cleanup comments
d849072 
ty Mondo, I intended to leave the comment once on each spec under `reset` as a reminder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjth bjth bjth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UH: Death Coil issue again
2 participants
@syrifgit @bjth