small refactor: make BuildW a proper data type #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| where | ||
| pulse = _nodeP pulse0 | ||
| parent = _nodeP parent0 | ||
|
|
||
| liftIOLater :: IO () -> Build () | ||
| liftIOLater x = RW.tell $ BuildW (mempty, mempty, Action x, mempty) | ||
| liftIOLater x = RW.tell mempty { bwLateIO = Action x } |
There was a problem hiding this comment.
Suggested change
| liftIOLater x = RW.tell mempty { bwLateIO = Action x } | |
| liftIOLater x = RW.tell emptyBuildW{ bwLateIO = Action x } |
Two requests on the matter of record syntax:
memptyis too generic a name. Could you defineemptyBuildW = mempty, so that it better resembles theBuildWconstructor?- Record syntax messes a little with the "spaces separate distinct arguments" rule. Could you remove the spaces between the value and
{? In this way, it becomes visually clear that{modifies the value.
There was a problem hiding this comment.
You got it!
|
|
|
@HeinrichApfelmus I think this is good to go |
|
Thanks! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just gives field names to each of the four components of a
BuildW.This would be a breaking change requiring a major version bump, except
BuildWis conspicuously missing from the export list of Reactive.Banana.Prim.Mid - unless we say that module doesn't follow the PVP - but was not exportingBuildWintentional?