added comments to "it" #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergio-fry
reviewed
Jul 17, 2024
sergio-fry
reviewed
Jul 17, 2024
lib/bddsm/describe.rb
Outdated
| @@ -12,7 +12,8 @@ def run | |||
| instance_eval(&@block) | |||
| end | |||
|
|
|||
| def it(&) | |||
| def it(comment = nil, &) | |||
| @comment = comment | |||
There was a problem hiding this comment.
Are we going to have single comment to all 'its' in a describe block? Looks like we should have separated
There was a problem hiding this comment.
Do you mean you need to comment out the remaining blocks?
There was a problem hiding this comment.
No. If we have multiple 'it'-s in a describe block, the last 'it' should override @comment, so the only one comment is going to be stored.
describe "test" do
it "this one is going to be removed" do
end
it "this one will be saved" do
end
endThere was a problem hiding this comment.
Ah, I understand. I'll fix it soon.
Build failed because after last commit in |
|
@sergio-fry right now on every push we have gem publish action. Maybe I will fix it in another PR? |
sergio-fry
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I understood the idea correctly, but open to other views.
Closed #29.