Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NWPS-1763-fe-training-programme-page-enhancements #311

Open
wants to merge 5 commits into
base: release/NWPS-Sprint-42
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions app/assets/hee/blocks/content/main/hee-card--summary/_summary.scss
Original file line number Diff line number Diff line change
Expand Up @@ -10,26 +10,15 @@
margin-top: nhsuk-spacing(2);
width: 12px;

@include mq($from: desktop) {
transform: rotate(180deg);
}
}

.hee-card--summary__heading {
@include mq($from: desktop) {
margin: 0;
}
}

.hee-card--summary__list {
@include nhsuk-typography-responsive(19);
list-style-type: none;
margin: 0;
padding: 0;

@include mq($from: desktop) {
display: none;
}
}

.hee-card--summary__item {
Expand Down Expand Up @@ -78,25 +67,16 @@
.hee-card--summary__heading {
margin-bottom: 0;

@include mq($from: desktop) {
@include nhsuk-responsive-margin(4, 'bottom');
}
}

.hee-card--summary__list {
display: none;

@include mq($from: desktop) {
display: block;
}
}

.hee-card--summary__toggle {
transform: rotate(180deg);

@include mq($from: desktop) {
transform: none;
}
}
}
}
37 changes: 1 addition & 36 deletions dist/assets/css/hee.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/assets/css/hee.min.css

Large diffs are not rendered by default.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion tests/playwright/specs/summary-card--desktop.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@ import { test, expect } from "@playwright/test";
test('Desktop Summary card: collapse and expand', async ({ page }) => {
await page.goto('/blocks/content/examples/main-card-summary.html');

const toggleLink = page.locator('.hee-card--summary__toggle');
// Desktop is expanded by default so need to check.
await toggleLink.click();
await expect(page.getByText('Competition ratio')).toBeVisible();

const toggleLink = page.locator('.hee-card--summary__toggle');

// Collapse card.
await toggleLink.click();
Expand Down
Loading