feat: get GMC by id #1040
Merged
feat: get GMC by id #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since findGmcDetailsIn() actually uses GMC numbers to search by, not ids. TIS21-6639
| @@ -698,6 +698,12 @@ public List<GmcDetailsDTO> findGmcDetailsIn(List<String> gmcIds) { | |||
| return responseEntity.getBody(); | |||
| } | |||
|
|
|||
| public GmcDetailsDTO getGmcDetailsById(Long id) { | |||
There was a problem hiding this comment.
I didn't include a javadoc because there aren't any in this file. I can amend if needed, but then perhaps we need to write javadocs for all the client functions?
There was a problem hiding this comment.
Please add the a javadoc please.
ReubenRobertsHEE
added a commit
to Health-Education-England/TIS-SYNC
that referenced
this pull request
Jan 13, 2025
Dependent on Health-Education-England/TIS-TCS#1040 TIS21-6639
hihilary
approved these changes
Jan 13, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since findGmcDetailsIn() actually uses GMC numbers to search by, not ids. tis-sync PR to use this new client function to follow.
TIS21-6639