Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DBC and HeeUser requests from TSS #252

Merged
merged 11 commits into from
Jul 12, 2024

Conversation

ReubenRobertsHEE
Copy link
Contributor

TIS21-6272

@ReubenRobertsHEE ReubenRobertsHEE marked this pull request as ready for review July 10, 2024 14:55
@ReubenRobertsHEE ReubenRobertsHEE requested review from a team, JosephKelly and CaiWillis and removed request for a team July 10, 2024 14:55
Copy link
Contributor

@JosephKelly JosephKelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One import to change.
I'm happy enough with the rest if you want to leave them... if you're up for addressing the code smell too, that would be appreciated!

Copy link
Contributor

@JosephKelly JosephKelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@ReubenRobertsHEE ReubenRobertsHEE merged commit 4b1754b into main Jul 12, 2024
1 check passed
@ReubenRobertsHEE ReubenRobertsHEE deleted the feat/handleRequestsForDbcAndHeeUserData branch July 12, 2024 15:49
Copy link

@ReubenRobertsHEE
Copy link
Contributor Author

Testing on staging shows there is a permission issue for the HeeUser requests from the Profile service. I'm looking into this now.

e.g.:

2024-07-15 08:11:40.048 ERROR 1 --- [   Thread-12274] u.n.tis.sync.service.DataRequestService  : 403 Forbidden: [Access is denied]
org.springframework.web.client.HttpClientErrorException$Forbidden: 403 Forbidden: [Access is denied]
	at org.springframework.web.client.HttpClientErrorException.create(HttpClientErrorException.java:109) ~[spring-web-5.2.7.RELEASE.jar:5.2.7.RELEASE]
	at org.springframework.web.client.DefaultResponseErrorHandler.handleError(DefaultResponseErrorHandler.java:184) ~[spring-web-5.2.7.RELEASE.jar:5.2.7.RELEASE]
	at org.springframework.web.client.DefaultResponseErrorHandler.handleError(DefaultResponseErrorHandler.java:125) ~[spring-web-5.2.7.RELEASE.jar:5.2.7.RELEASE]
	at org.springframework.web.client.ResponseErrorHandler.handleError(ResponseErrorHandler.java:63) ~[spring-web-5.2.7.RELEASE.jar:5.2.7.RELEASE]
	at org.springframework.web.client.RestTemplate.handleResponse(RestTemplate.java:782) ~[spring-web-5.2.7.RELEASE.jar:5.2.7.RELEASE]
	at org.springframework.web.client.RestTemplate.doExecute(RestTemplate.java:740) ~[spring-web-5.2.7.RELEASE.jar:5.2.7.RELEASE]
	at org.springframework.web.client.RestTemplate.execute(RestTemplate.java:674) ~[spring-web-5.2.7.RELEASE.jar:5.2.7.RELEASE]
	at org.springframework.web.client.RestTemplate.exchange(RestTemplate.java:612) ~[spring-web-5.2.7.RELEASE.jar:5.2.7.RELEASE]
	at com.transformuk.hee.tis.profile.client.service.impl.ProfileServiceImpl.getSingleAdminUser(ProfileServiceImpl.java:188) ~[profile-client-2.8.1.jar:na]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants