Refactor tech debt template class design #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The SonarCloud code analysis seems to be a little tricky. 😞 |
hihilary
requested review from
a team,
JosephKelly,
jayanta2018 and
CaiWillis
and removed request for
a team
TIS21-5812
hihilary
force-pushed
the
refactor-tech-debt-template-class-design
branch
from
6fb7288 to
e449ca7
Compare
|
I did a force push to remove some temporary comment of a commit. |
Reducing LoC and redundancy TIS21-5812: Add nightly job for Funding Status TIS21-6044: Address code duplication smells
…ierarchyDRYer-TIS21-5812 refactor/class hierarchy "d.r.y."er tis21-5812
…ebt-template-class-design-code-smells fix: code smells suggested by sonar
…-debt-template-class-design
TIS21-5812
|
jayanta2018
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new abstract
CommonSyncJobTemplateclass, and 2 templates (TrustAdminSyncJobTemplate,PersonDateChangeCaptureSyncJobTemplate) extends it.To move
doDataSyncto the common sync template, I also added some extra methods to initialise the ids and update ids, and unified the method signature ofcollectData,convertData, etc.TIS21-5812