fix: code smells and coverage

src/main/java/uk/nhs/tis/sync/dto/HeeUserDmsDto.java

@@ -2,6 +2,9 @@
 
 import lombok.Data;
 
+/**
+ * A DTO for transferring HeeUser data to the DMS.
+ */
 @Data
 public class HeeUserDmsDto {
   private final String name;

src/main/java/uk/nhs/tis/sync/service/DataRequestService.java

@@ -83,12 +83,12 @@ public List<Object> retrieveDtos(Map<String, String> message) {
             .collect(Collectors.toList());
       }
 
-      if(table.equals(TABLE_HEE_USER) && message.containsKey("name")) {
+      if (table.equals(TABLE_HEE_USER) && message.containsKey("name")) {
         String name = message.get("name");
         return createNonNullList(profileServiceImpl.getSingleAdminUser(name));
       }
 
-      if(table.equals(TABLE_DBC) && message.containsKey("dbc")) {
+      if (table.equals(TABLE_DBC) && message.containsKey("dbc")) {
         String dbc = message.get("dbc");
         ResponseEntity<DBCDTO> responseEntity = referenceServiceImpl.getDBCByCode(dbc);
         return createNonNullList(responseEntity.getBody());

src/test/java/uk/nhs/tis/sync/job/PersonRecordStatusJobIntegrationTest.java

@@ -14,7 +14,6 @@
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
 import org.junit.runner.RunWith;
-import org.mockito.InjectMocks;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.boot.test.mock.mockito.MockBean;

src/test/java/uk/nhs/tis/sync/mapper/HeeUserMapperTest.java

@@ -10,9 +10,11 @@
 import java.util.Set;
 import org.junit.Before;
 import org.junit.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
 import uk.nhs.tis.sync.dto.HeeUserDmsDto;
 
-public class HeeUserMapperTest {
+class HeeUserMapperTest {
 
   private HeeUserMapper mapper;
 
@@ -59,4 +61,12 @@ public void shouldMapAHeeUserDtoToADataDmsDto() {
     assertEquals("phone", heeUserDmsDto.getPhoneNumber());
     //other HeeUserDto properties are ignored
   }
+
+  @ParameterizedTest
+  @ValueSource(booleans = {false, true})
+  void shouldMapBooleansToZeroOrOneString(boolean bool) {
+    heeUserDto.setActive(bool);
+    HeeUserDmsDto heeUserDmsDto = mapper.toDmsDto(heeUserDto);
+    assertEquals(bool ? "1" : "0", heeUserDmsDto.getActive());
+  }
 }

src/test/java/uk/nhs/tis/sync/service/DataRequestServiceTest.java

@@ -829,6 +829,18 @@ void shouldReturnEmptyWhenHeeUserNotFound() {
     assertThat("Unexpected DTO count.", heeUsers.size(), is(0));
   }
 
+  @Test
+  void shouldReturnEmptyWhenHeeUserMessageHasWrongKey() {
+    Map<String, String> message = new HashMap<String, String>() {{
+      put("table", "HeeUser");
+      put("another key", HEE_USER_NAME);
+    }};
+    List<Object> heeUsers = service.retrieveDtos(message);
+
+    assertThat("Unexpected DTO count.", heeUsers.size(), is(0));
+    verifyNoInteractions(profileService);
+  }
+
   @Test
   void shouldReturnDbcWhenDbcFound() {
     DBCDTO expectedDto = new DBCDTO();
@@ -858,4 +870,16 @@ void shouldReturnEmptyWhenDbcNotFound() {
 
     assertThat("Unexpected DTO count.", dbcs.size(), is(0));
   }
+
+  @Test
+  void shouldReturnEmptyWhenDbcMessageHasWrongKey() {
+    Map<String, String> message = new HashMap<String, String>() {{
+      put("table", "DBC");
+      put("another key", DBC_VALUE);
+    }};
+    List<Object> dbcs = service.retrieveDtos(message);
+
+    assertThat("Unexpected DTO count.", dbcs.size(), is(0));
+    verifyNoInteractions(referenceService);
+  }
 }