Having spec return NULL as filter (#206)

Happyr · Aug 9, 2019 · 162ff2a · 162ff2a
1 parent 030a8aa
commit 162ff2a
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/src/Specification/Having.php b/src/Specification/Having.php
@@ -33,6 +33,12 @@ public function modify(QueryBuilder $qb, $dqlAlias)
         if ($this->child instanceof QueryModifier) {
             $this->child->modify($qb, $dqlAlias);
         }
+
+        if ($this->child instanceof Filter) {
+            $qb->having($this->child->getFilter($qb, $dqlAlias));
+        } else {
+            $qb->having($this->child);
+        }
     }
 
     /**
@@ -43,12 +49,6 @@ public function modify(QueryBuilder $qb, $dqlAlias)
      */
     public function getFilter(QueryBuilder $qb, $dqlAlias)
     {
-        if ($this->child instanceof Filter) {
-            $qb->having($this->child->getFilter($qb, $dqlAlias));
-        } else {
-            $qb->having($this->child);
-        }
-
-        return '';
+        return;
     }
 }