Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all dashboards requests will include initial query string #1651

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Alexei000
Copy link

If initial query to dashboard (i.e. /hangfire) also provides a query string, this will be used for all links and requests within the dashboard.

This is useful to make the dashboard accessible based on a bearer token or similar. See this discussion.

If the query string is empty (default case), no link / url is changed.

@odinserj
Copy link
Member

Hi @Alexei000, this is an interesting idea to make everything work with SPA. But I have a question related to security – do I understand everything correctly, and some other person who can see the URL and that query string may use it to access the Dashboard UI?

@Alexei000
Copy link
Author

Hello, @odinserj! Indeed this is an issue, although I expect the string not to be entirely visible. This should be regarded more as a workaround until a better solution is found.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants