Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made some a couple class public along with a few members #1419

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Topkapi
Copy link

@Topkapi Topkapi commented May 3, 2019

Hello Sergey,

Thanks for making an awesome library. I have been using it for years and always enjoy working with it.

For my latest job, I had to add some bits to the dashboard but to do that succinctly, I needed to have some of the internal classes from HangFire. Please take a look at the changes and if they are not too much of a bother, you can merge them. Will make it easy for me to keep things fresh.

Thanks.

@odinserj
Copy link
Member

odinserj commented May 7, 2019

@Topkapi, thanks for the PR. Could you tell me more why these changes are necessary and what you are overriding in a derived class?

@Topkapi
Copy link
Author

Topkapi commented May 8, 2019

Hi @odinserj,

I wanted to add new custom states and show them on the built in dashboard. I could not do that without making the changes in this PR.
image

I hope that by making those changes other people will be able to add custom states and show them on the dashboard.

Thanks.

@Powerz
Copy link

Powerz commented Aug 19, 2019

Hi @odinserj , could you give any update on this PR? Is it going to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants