-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EmmyLua: save timestamps of docs.json to skip if no change #278
Conversation
@muescha happy to see someone else was experiencing startup lag in Hammerspoon caused by EmmyLua uneccessarily reading the jsonDocs files. I was about to submit a PR for this before I came across yours. The main difference is that I am storing timestamps in Looking at yours, I do think storing the timestamp in the local settings variable is the way to go. Hope this PR gets merged, as it significantly speeds up Hammerspoon's startup time when there are no new docs for EmmyLua to generate. |
My solution don't blow up the internal memory with data, which is maybe unused when he deactive the spoon. Storing the timestamps in a file gives the user the control over the metadata. A user can not delete the (unknown) meta data stored in |
Thanks for pointing that out. I had not considered having the data hanging around. |
Co-authored-by: Muescha <[email protected]>
@cmsj irc GitHub Action ist hanging |
I believe this was ready to merge, could we re-run the CI check? |
change formatting - remove whitespace - to get CI Checks run again
@pecigonzalo I changed some whitespace to re-run CI Check - now all checks have passed :) |
thx :) |
save timestamps in to a file
timestamps.json
to check ifdocs.json
are changed.if not changed then skip the file check
add also a check to skip the writing to
timestamps.json