Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing to packages #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Krovatkin
Copy link

This PR adds missing __init__.py to any directory with python files, so setup.py can find all packages and install them correctly.

@Krovatkin
Copy link
Author

@Haiyang-W Thanks for the great work! I've noticed I can't use this package as a 3rd party dependency installed in site-packages due to setup.py not copying all the python files into the package.

@chenshi3
Copy link
Collaborator

@Krovatkin Thanks for your contribution. I will check and merge this PR.

@chenshi3
Copy link
Collaborator

@Haiyang-W Thanks for the great work! I've noticed I can't use this package as a 3rd party dependency installed in site-packages due to setup.py not copying all the python files into the package.

The __init__.py under the tools folder is not necessary. You may consider deleting these files.

@Krovatkin Krovatkin force-pushed the master branch 2 times, most recently from f1e4cc3 to 63099c6 Compare July 30, 2023 20:08
@Krovatkin
Copy link
Author

Krovatkin commented Jul 30, 2023

I believe if we remove tools/__init__.py, we won't be able to use any one of these as packages either:

tools/__init__.py
tools/eval_utils/__init__.py
tools/process_tools/__init__.py
tools/train_utils/__init__.py
tools/visual_utils/__init__.py

Could you please advise me if this behaviour is what we want?

@Krovatkin
Copy link
Author

@chenshi3 ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants