Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added UDT::devel_setfakeloss testing utility #966

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added UDT::devel_setfakeloss testing utility #966

wants to merge 1 commit into from

Conversation

ethouris
Copy link
Collaborator

This can be used from both UDT::devel_setfakeloss function and the srt-test-live application using the fakeloss attribute for SRT URI.

Syntax: fakeloss=LENGTH+INTERVAL where:

LENGTH: The number of consecutively dropped DATA packets
INTERVAL: how many packets are expected to be delivered normally between the loss events.

The real interval between packet loss events is a sum of these two plus a small random value from the range 8-24.

@ethouris ethouris added Priority: Medium Type: Enhancement Indicates new feature requests Status: Review Needed [core] Area: Changes in SRT library core [build] Area: Changes in build files labels Nov 19, 2019
@ethouris ethouris added this to the v1.4.2 milestone Nov 19, 2019
maxsharabayko
maxsharabayko reviewed Jul 27, 2020
View reviewed changes
Copy link
Collaborator

@maxsharabayko maxsharabayko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ENABLE_DEVEL_API can now be slightly improved using SRT CMakeLists' ENFORCE_* option.

testing/testmedia.cpp
#if ENABLE_DEVEL_API
UDT::devel_setfakeloss(sock, m_fakeloss);
#else
Verb() << "ERROR: fakeloss not enabled at compile time";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"not" -> "is not"

@maxsharabayko maxsharabayko modified the milestones: v1.5.0, v1.5.1 Jul 27, 2020
@mbakholdina mbakholdina modified the milestones: v1.5.1, Backlog May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsharabayko maxsharabayko maxsharabayko left review comments

Assignees
No one assigned
Labels
[build] Area: Changes in build files [core] Area: Changes in SRT library core Priority: Medium Type: Enhancement Indicates new feature requests
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@ethouris @maxsharabayko @mbakholdina