[core] Minor ACK variables clean up. #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
force-pushed
the
develop/ack_timers_mnor
branch
2 times, most recently
from
74ded65 to
69eb974
Compare
ethouris
reviewed
Jul 17, 2019
maxsharabayko
force-pushed
the
develop/ack_timers_mnor
branch
from
69eb974 to
66d87ff
Compare
ethouris
reviewed
Sep 5, 2019
maxsharabayko
force-pushed
the
develop/ack_timers_mnor
branch
6 times, most recently
from
b69733c to
e5133a0
Compare
ethouris
reviewed
Sep 13, 2019
ethouris
reviewed
Sep 13, 2019
maxsharabayko
force-pushed
the
develop/ack_timers_mnor
branch
from
e5133a0 to
a9d7153
Compare
ethouris
approved these changes
Sep 13, 2019
maxsharabayko
force-pushed
the
develop/ack_timers_mnor
branch
from
d2836c7 to
bd10cd4
Compare
* m_ullACKInt_tk used at initialization * Removed unused m_iACKPeriod from FileCC * ACK event variant type changed to signed integer * SrtCongestionControlBase: renamed ACKInterval() -> ACKMaxPackets() * SrtCongestionControlBase: renamed ACKPeriod() -> ACKTimeout_us()
maxsharabayko
force-pushed
the
develop/ack_timers_mnor
branch
from
bd10cd4 to
5bfefab
Compare
maxsharabayko
force-pushed
the
develop/ack_timers_mnor
branch
from
5bfefab to
67b71cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
m_iACKPeriodfrom FileCCSrtCongestionControlBase: renamedACKInterval()->ACKMaxPackets()SrtCongestionControlBase: renamedACKPeriod()->ACKTimeout_us()ATR_OVERRIDEtoFECFilterBuiltin::arqLevel()Fixes #253 - no warnings during build in Travis.