Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fixed a data race on listener's config. #2998

Merged
merged 1 commit into from
Aug 7, 2024
Merged

[core] Fixed a data race on listener's config. #2998

merged 1 commit into from
Aug 7, 2024

Conversation

maxsharabayko
Copy link
Collaborator

Fixed a data race upon a simultaneous access to listener's config (CUDT::m_config) from SRT internal newConnection(..) and the app thread called for srt_listen(). Locking the listener's m_ConnectionLock.

Replaces #2961.
Fixes #2970.

@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Aug 7, 2024
@maxsharabayko maxsharabayko added this to the v1.5.4 milestone Aug 7, 2024
@maxsharabayko maxsharabayko mentioned this pull request Aug 7, 2024
Open
8 tasks
@maxsharabayko maxsharabayko merged commit 4270a11 into Haivision:master Aug 7, 2024
12 checks passed
@maxsharabayko maxsharabayko deleted the hotfix/data-race-listen-setopt branch August 7, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
v1.5.4
Development

Successfully merging this pull request may close these issues.

[BUG] Lock order violation: m_ConnectionLock and m_LSLock.
1 participant
@maxsharabayko