[core] Removed a wrong assertion about ACK timestamp. #2971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Maintenance
ethouris
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug assertion was added in PR #1628 (SRT v1.4.3). It assumes a timestamp of an ACK packet is positive.
However, a timestamp value of 0 is a valid value. For an ACK it is unlikely to happen as the first full ACK is sent only after 10 ms (except for issue #2829 in SRT v1.5.3). Also handshaking takes some time.
Still lite ACK may be sent earlier in case of higher data rates.
Anyway, removing the debug assertion.