Refax around Window measurement facility #2857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Maintenance
srtcore/utilities.h
Outdated
| for (; p != end; ++p, ++para) | ||
| { | ||
| // Throw away those that don't fit in the filter | ||
| if (*p < filter.lower || *p > filter.upper) |
There was a problem hiding this comment.
To be identical with the previous version should be <= and >= here.
There was a problem hiding this comment.
Right! Forgot that De Morgan's laws apply also to relative operators.
maxsharabayko
requested changes
Jan 18, 2024
|
Damn, it was the same in two different places :) I'm thinking maybe it should be also extracted... |
maxsharabayko
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted longer and copy-paste-looking code into external functions. Potentially they can be reused in other measurement activities.