[core] Slightly optimize the RCV drop by message number. #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gou4shi1
commented
Mar 10, 2023
gou4shi1
commented
Mar 10, 2023
gou4shi1
commented
Mar 10, 2023
| minDroppedOffset = offPos(m_iStartPos, i); | ||
| else | ||
| minDroppedOffset = min(offPos(m_iStartPos, i), minDroppedOffset); | ||
| minDroppedOffset = offPos(m_iStartPos, i); |
There was a problem hiding this comment.
As said in #2661 (comment)
ethouris
reviewed
Mar 10, 2023
ethouris
reviewed
Mar 10, 2023
ethouris
reviewed
Mar 10, 2023
gou4shi1
force-pushed
the
minor-improve-logs
branch
2 times, most recently
from
cb5d834
to
37c6683
Compare
gou4shi1
commented
Mar 11, 2023
| @@ -293,7 +294,9 @@ int CRcvBuffer::dropMessage(int32_t seqnolo, int32_t seqnohi, int32_t msgno, Dro | |||
| if (bKeepExisting && bnd == PB_SOLO) | |||
| { | |||
| bDropByMsgNo = false; // Solo packet, don't search for the rest of the message. | |||
| LOGC(rbuflog.Debug, log << "CRcvBuffer.dropMessage(): Skipped dropping an exising SOLO packet %" << packetAt(i).getSeqNo() << "."); | |||
There was a problem hiding this comment.
fixed typo: exising
|
any comment? |
gou4shi1
force-pushed
the
minor-improve-logs
branch
from
dfe15d5
to
f4c8973
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #2686 +/- ##
==========================================
- Coverage 67.33% 67.15% -0.18%
==========================================
Files 99 99
Lines 20166 20163 -3
==========================================
- Hits 13579 13541 -38
- Misses 6587 6622 +35
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
maxsharabayko
changed the title
maxsharabayko
added
Type: Maintenance
maxsharabayko
approved these changes
Aug 9, 2023
guilletrejo
added a commit
to swxtchio/srt
that referenced
this pull request
Aug 23, 2023
* [core] Fix crypto mode auto for listener sender (Haivision#2711). Co-authored-by: oviano <[email protected]> * [build] Upgraded CI: ubuntu to version 20.04 (Haivision#2682). * [docs] Added the link for registration in slack to the getting started table (Haivision#2721). * [core] Fixed FEC Emergency resize crash (Haivision#2717). Fixed minimum history condition. * [core] Fixed various compiler warnings on various platforms (Haivision#2679). * [core] Minor fix of variable shadowing. * [tests] Minor fix of variable shadowing. * [build] Add -Wshadow=local to CMake build flags. Supported since GCC 7.0. * [core] Correct remaining endianness issues Fixes the last two remaining test failures on big-endian. These operations were all already no-ops on little-endian, and unnecessarily byteswapped the IP addresses on big-endian. Closes: Haivision#2697 * [docs] Minor updates to AEAD docs plus changed v1.6.0 to 1.5.2 in some files * [build] Fix downversioning of _WIN32_WINNT (Haivision#2754). * [core] Fixed unhandled error in haicrypt (Haivision#2685). * [core] Use overlapped WSASendTo to avoid loss in UDP sending (Haivision#2632). * [core] Add volatile keyword to asm block in rdtsc (Haivision#2759). * [core] Fixed srctime from closing socket was mistakenly cleared * [core] Fixed group read-ready epoll events. * [core] Removed unused CUDTGroup::m_Positions. * [core] Perf improvement of group reading. * [core] Fixed RCV buffer initialization in Rendezvous. * [docs] Updating the explicit information for binding to IPv6 wildcard (Haivision#2765). * [tests] Added custom main with transparent parameters for tests (Haivision#2681). * [core] Fix memory leak when can't buffer a HS packet (Haivision#2757). * [core] Refactor CRcvQueue::storePkt(..) for better resource management (Haivision#2775). * [core] Fix hang up on not enough space in the RCV buffer (Haivision#2745). When there is space available in the receiving buffer after it is full, send an ack to allow the sender to resume transmission. Reschedule sending if ACK decreases the flight span after sending is congested. Co-authored-by: Maxim Sharabayko <[email protected]> * [core] fix tsbpd() may deadlock with processCtrlShutdown() * [core] Slightly optimize the RCV drop by message number (Haivision#2686). Some minor improvements of logs and comments. * [core] Rejection not undertaken in rendezvous after KMX failure (Haivision#2692). * [core] Fix: In rendezvous when processing resulted in ACCEPT it was still sending rejection * [core] Minor code clean up in CRateEstimator. * [core] Initialize ISN and PeerISN in CUDT. * [core] Drop unencrypted packets in GCM mode. * [apps] Fix the build for target without IP_ADD_SOURCE_MEMBERSHIP (Haivision#2779). * [core] Added maximum BW limit for retransmissions (Haivision#2714). * [API] SRT version raised to 1.5.3. * [apps] Fixed conditional IP_ADD_SOURCE_MEMBERSHIP in testmedia (Haivision#2780). * [core] Fixed SRT_ATTR_REQUIRES use. * [build] Added missing public header files in Windows binary installer (Haivision#2784). The header file access_control.h was added to the source tree at some point but was not added to the Windows installer. --------- Co-authored-by: Maxim Sharabayko <[email protected]> Co-authored-by: oviano <[email protected]> Co-authored-by: Sektor van Skijlen <[email protected]> Co-authored-by: Maria Sharabayko <[email protected]> Co-authored-by: Maxim Sharabayko <[email protected]> Co-authored-by: matoro <[email protected]> Co-authored-by: Maria Sharabayko <[email protected]> Co-authored-by: Steve Lhomme <[email protected]> Co-authored-by: Aaron Jencks <[email protected]> Co-authored-by: Guangqing Chen <[email protected]> Co-authored-by: john <[email protected]> Co-authored-by: yomnes0 <[email protected]> Co-authored-by: Mikołaj Małecki <[email protected]> Co-authored-by: Jose Santiago <[email protected]> Co-authored-by: Thierry Lelegard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.