Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Added jitter tracing #2256

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maxsharabayko
Copy link
Collaborator

Adding RFC3550-like jitter metrics for:

  • jitter of incoming data packets over UDP on the receiving side;
  • jitter of sending packets over UDP on the sending side;
  • jitter of reading packets from SRT by the receiving app.

TODO

  • Statistics API is affected (more fields in SRT_BSTATS). Consider API/ABI compatibility.
  • Document how jitter is calculated.

@maxsharabayko maxsharabayko added Type: Enhancement Indicates new feature requests [core] Area: Changes in SRT library core [API] Area: Changes in SRT library API labels Mar 2, 2022
@maxsharabayko maxsharabayko added this to the v1.4.5 milestone Mar 2, 2022
@maxsharabayko maxsharabayko self-assigned this Mar 2, 2022
@maxsharabayko maxsharabayko modified the milestones: v1.4.5, Next Release Apr 25, 2022
@BlueWaterCrystal
Copy link

Is it currently possible to test the PR by itself?
bstats jitter seems to return 0 On receiver and sender jitter.

@maxsharabayko
Copy link
Collaborator Author

@BlueWaterCrystal
Thanks for reporting. Forgot to copy internal jitter values to the SRT stats API. :)
It should work now (have not checked myself yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[API] Area: Changes in SRT library API [core] Area: Changes in SRT library core Type: Enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants