Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] make sure CRcvLossList::remove() will not loop infinitely #2193

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gou4shi1
Copy link
Contributor

@gou4shi1 gou4shi1 commented Dec 1, 2021

#2192 (comment)
This PR may not cure that issue, but this loop deserve a sanity check.

@codecov-commenter
Copy link

Codecov Report

Merging #2193 (bafb171) into master (6ae42c6) will increase coverage by 0.13%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2193      +/-   ##
==========================================
+ Coverage   65.77%   65.91%   +0.13%     
==========================================
  Files          94       94              
  Lines       19489    19492       +3     
==========================================
+ Hits        12819    12848      +29     
+ Misses       6670     6644      -26     
Impacted Files Coverage Δ
srtcore/list.cpp 77.37% <50.00%> (+1.31%) ⬆️
srtcore/queue.cpp 79.68% <0.00%> (-1.17%) ⬇️
srtcore/core.cpp 60.64% <0.00%> (+0.66%) ⬆️
srtcore/cache.h 83.07% <0.00%> (+3.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ae42c6...bafb171. Read the comment docs.

@maxsharabayko maxsharabayko added [core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior labels Dec 1, 2021
@maxsharabayko maxsharabayko added this to the v1.4.5 milestone Dec 1, 2021
@maxsharabayko maxsharabayko modified the milestones: v1.5.0, Backlog Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants