Move public headers into directory structure mimicking installed structure #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cture This facilitates building applications linking to srt without installing the libraries (i.e.: projects that build libsrt as a subproject).
|
Relates to #1621. |
Oh I wasn't aware there was already an issue regarding this, it was a bother I encountered in one of my own projects that I resolved via very nasty hacks and I'd rather see an upstream solution. My 2 cents for choosing the include/srt path and only putting the public headers there: it also simplifies looking at the source, I don't have to browse through a long file list to find just the public API headers. Sorry if I stepped on anybodies toes! |
|
The contribution is always welcome here! Changes to the structure have to be made cautiously to not impede the ongoing work and other projects. |
maxsharabayko
added
[core]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This facilitates building applications linking to srt without installing
the libraries (i.e.: projects that build libsrt as a subproject).