[core] Refactored ACK window management to avoid false error reports #1888
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #253
This refactors the
acknowledge
function from Window tools, which not only returns what it was supposed to return so far as results, but also returns a status that allows to distinguish the reason as to why the ACK node could not be used this time to calculate RTT:Effectively, only if OK is returned should the RTT calculation be taken. If OLD, simply ignore the case (no log required), otherwise issue an IPE log message, as these situations shall never happen in a healthy code.
The body of
acknowledge
has been also completely rewritten for clarity and better performance. Also test cases have been provided.