-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Added SRTO_MININPUTBW #1791
[core] Added SRTO_MININPUTBW #1791
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Way simpler than the SRTO_OUTPACEMODE option it replaces. Maintain backward compatibility but setting both SRTO_INPUTBW and SRTO_MININPUTBW would lead to unexpected results. The documentation should clarify that SRTO_MININPUTBW is a floor to the internally measured input rate.
The proposed behavior is that |
5a43fc7
to
d7208d7
Compare
TestSending starts at 1 Mbps, five seconds later sending rate is increased to 5 Mbps. Input BW EstimationSRTO_MAXBW = 0
SRTO_INPUTBW = 0; // Estimate internally
SRTO_OHEADBW = 25;
SRTO_MININPUTBW = 0; Input BW Estimation + Setting Min Input BWSRTO_MAXBW = 0
SRTO_INPUTBW = 0; // Estimate internally
SRTO_OHEADBW = 25;
SRTO_MININPUTBW = 1 Mbps;
// Once "encoder" changes sending rate from 1Mbps to 5Mbps
SRTO_MININPUTBW = 5 Mbps; |
02e05b5
to
1656ada
Compare
1656ada
to
99862bd
Compare
A simplification of #1541 and #1383.
The proposed
SRTO_MININPUTBW
socket option allows specifying the minimum input bitrate estimate used to set bandwidth limit.Effective when
SRTO_INPUTBW = 0
-> input bitrate estimation.TODO