[FR] Added response time statistics #1538
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethouris
added
[API]
srtcore/core.h
Outdated
Comment on lines
1192
to
1195
| /// This function records the passed current time as the last response time. | ||
| /// Before doing it, however, it checks if there exist any previous such time | ||
| /// and updates statistics accordingly. | ||
| void calculateResponseTime(const time_point& now) |
There was a problem hiding this comment.
If it records the time, then a better name could be recordResponseTime.
Otherwise this operation is unexpected: m_tsLastRspTime = now;.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1520
This PR adds the new statistical fields per socket that allow to show the average and maximum response time. The response time is the time distance between the time when the sending function is called and the last received packet from the peer. The average value is only for orientation as to how much this value varies. The maximum value is the most important for orientation as to how much the response time can span and how to set the limit for groubstabtimeo.