Thread API wrappers required for thread logging #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethouris
added
[core]
There was a problem hiding this comment.
@ethouris This PR is already outdated and can be closed, right?
|
It's long not updated, but the update is impossible until your fixes for timers are merged - in particular, the one that eliminates the type definition difference for monotonic condition variable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends: #1049
This applies part of the thread logging, which comprises thread API wrappers. This includes:
jointhread: refers topthread_joinisthread: checks if the thread id value is equal (taken as a good deal that thread isn't running)Not provided wrappers for
pthread_createandpthread_t. Possible wrappers for them should be more high level and therefore were not created. They should involve a wrapper over a handler function so that the possible thread logging on a new started thread or exited thread comes from the elevated handler.This is the part that is only required for thread logging.