-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread API wrappers required for thread logging #1054
Open
ethouris
wants to merge
9
commits into
Haivision:master
Choose a base branch
from
ethouris:dev-thread-logging-thread-wrappers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Thread API wrappers required for thread logging #1054
ethouris
wants to merge
9
commits into
Haivision:master
from
ethouris:dev-thread-logging-thread-wrappers
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ethouris This PR is already outdated and can be closed, right?
It's long not updated, but the update is impossible until your fixes for timers are merged - in particular, the one that eliminates the type definition difference for monotonic condition variable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[core]
Area: Changes in SRT library core
Priority: High
Type: Enhancement
Indicates new feature requests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends: #1049
This applies part of the thread logging, which comprises thread API wrappers. This includes:
jointhread
: refers topthread_join
isthread
: checks if the thread id value is equal (taken as a good deal that thread isn't running)Not provided wrappers for
pthread_create
andpthread_t
. Possible wrappers for them should be more high level and therefore were not created. They should involve a wrapper over a handler function so that the possible thread logging on a new started thread or exited thread comes from the elevated handler.This is the part that is only required for thread logging.