Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse url escaped values for model names #391

Merged
merged 1 commit into from
Mar 16, 2024
Merged

Conversation

tazlin
Copy link
Member

@tazlin tazlin commented Mar 15, 2024

This will allow the /v2/status/models/{model_name} endpoint to support forward slashes in the model name, as is common for text models. For example, aphrodite%2FNeverSleep%2FNoromaid-13b-v0.3 will become aphrodite/NeverSleep/Noromaid-13b-v0.3.

This will allow the `/v2/models/{model_name}` endpoint to support forward slashes in the model name, as is common for text models. For example, `aphrodite%2FNeverSleep%2FNoromaid-13b-v0.3` will become `aphrodite/NeverSleep/Noromaid-13b-v0.3`.
@tazlin tazlin added the allow-ci A PR with this label will run through CI. label Mar 15, 2024
@tazlin tazlin requested a review from db0 March 15, 2024 14:24
@db0
Copy link
Member

db0 commented Mar 16, 2024

LGTM

@db0 db0 merged commit 1dfef86 into main Mar 16, 2024
2 checks passed
@db0 db0 deleted the url-decode-model-names branch March 16, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allow-ci A PR with this label will run through CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants