Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react1-week2/Ihor #271

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

react1-week2/Ihor #271

wants to merge 2 commits into from

Conversation

IhorKulytskyi
Copy link

Homework week2

@github-actions github-actions bot changed the title React1 week2/ihor react1-week2/Ihor Mar 24, 2024
Copy link

@SvitlanaBurlaka SvitlanaBurlaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! ⭐ I like that you implemented the delete feature! Just one important note: when the application is small, you might think that there is no need to move functions like 'addTodo' and 'toggleDone', etc., outside of App.jsx file. However, it would be good practice to start keeping your App.jsx file as clean as possible from now on. Here's why:

  1. You might want to reuse functions in other components, making your code reusable.
  2. Each file or component should have a single responsibility.
  3. It will make your code more readable. This is crucial when you work in a team, and another person would need to go and fix something. (It's good to fix just one broken component, instead of touching the main App.jsx file where there can be a lot of important things, right?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants