Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: UI improvements #53

Merged
merged 5 commits into from
Jan 23, 2025
Merged

feat: UI improvements #53

merged 5 commits into from
Jan 23, 2025

Conversation

Norbiros
Copy link
Member

Before:
image
After:
image

@Norbiros Norbiros requested a review from a team as a code owner January 21, 2025 16:44
goteusz-maszyk
goteusz-maszyk previously requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@goteusz-maszyk goteusz-maszyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the start button, it's worse

@wikipop
Copy link
Contributor

wikipop commented Jan 21, 2025 •
edited
Loading

Bro change the button's text color from white to blackish (maybe the one we use on bg) cos ITS INSANELY UNREADABLE

@wikipop
Copy link
Contributor

wikipop commented Jan 21, 2025

Tbh idk why u changed navbar color, darker one imo better but i havn't seen it in action

wojpo
wojpo reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@wojpo wojpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk for me this button looks even worse

wojpo
wojpo previously approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@wojpo wojpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhh i guess its ok now.

@wikipop wikipop marked this pull request as draft January 23, 2025 12:11
wikipop
wikipop requested changes Jan 23, 2025
View reviewed changes
frontend/app/components/Navbar.vue Outdated Show resolved Hide resolved
@Norbiros Norbiros marked this pull request as ready for review January 23, 2025 13:16
@Norbiros Norbiros requested review from wikipop and wojpo January 23, 2025 14:56
wikipop
wikipop approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@wikipop wikipop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hero rewrite will be necessary

@Norbiros Norbiros merged commit bde6384 into master Jan 23, 2025
2 checks passed
@Norbiros Norbiros deleted the feat/primary-colors branch January 23, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojpo wojpo wojpo approved these changes

@wikipop wikipop wikipop approved these changes

@goteusz-maszyk goteusz-maszyk Awaiting requested review from goteusz-maszyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Norbiros @wikipop @goteusz-maszyk @wojpo