Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement temporary landing site #46

Merged
merged 7 commits into from
Jan 21, 2025
Merged

Conversation

WitaLisek
Copy link
Contributor

@WitaLisek WitaLisek commented Jan 18, 2025

According to Norbiros "Resolves #11"
Rest is self explanatory

@WitaLisek WitaLisek requested review from a team and Norbiros as code owners January 18, 2025 19:37
frontend/app/pages/index.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@goteusz-maszyk goteusz-maszyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also some warnings from console:

WARN  [Icon] Collection mdi is not found locally
We suggest to install it via npm i -D @iconify-json/mdi to provide the best end-user experience.


 WARN  [Icon] Collection octicon is not found locally
We suggest to install it via npm i -D @iconify-json/octicon to provide the best end-user experience.```

frontend/app/pages/index.vue Outdated Show resolved Hide resolved
frontend/app/pages/index.vue Outdated Show resolved Hide resolved
Norbiros
Norbiros previously approved these changes Jan 19, 2025
wojpo
wojpo previously requested changes Jan 20, 2025
Copy link
Contributor

@wojpo wojpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve conflicts

@Norbiros Norbiros dismissed stale reviews from wojpo and goteusz-maszyk January 21, 2025 12:44

Already fixed

@WitaLisek WitaLisek merged commit d510817 into master Jan 21, 2025
2 checks passed
@Norbiros Norbiros deleted the feat/landing-site branch January 21, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: Implement temporary landing site
5 participants