Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added view teams, get team, get your team, create team endpoints #41

Merged
merged 2 commits into from
Jan 22, 2025
Merged

feat: Added view teams, get team, get your team, create team endpoints #41

merged 2 commits into from
Jan 22, 2025

Conversation

Kubaryt
Copy link
Member

@Kubaryt Kubaryt commented Jan 17, 2025 •
edited by Norbiros
Loading

todo: tests

Resolves: #37
Resolves #44

@Kubaryt Kubaryt self-assigned this Jan 17, 2025
Norbiros
Norbiros requested changes Jan 18, 2025
View reviewed changes
backend/src/main.rs Outdated Show resolved Hide resolved
backend/src/utils/error.rs Outdated Show resolved Hide resolved
backend/src/utils/error.rs Outdated Show resolved Hide resolved
backend/src/routes/teams/view_teams.rs Outdated Show resolved Hide resolved
backend/src/routes/teams/view_teams.rs Outdated Show resolved Hide resolved
backend/src/routes/teams/get_my_team.rs Outdated Show resolved Hide resolved
backend/src/models/teams.rs Outdated Show resolved Hide resolved
@Kubaryt Kubaryt marked this pull request as ready for review January 19, 2025 15:01
@Kubaryt Kubaryt requested a review from a team as a code owner January 19, 2025 15:01
@Kubaryt Kubaryt requested review from Norbiros and wojpo January 19, 2025 15:01
goteusz-maszyk
goteusz-maszyk previously requested changes Jan 19, 2025
View reviewed changes
backend/src/utils/error.rs Outdated Show resolved Hide resolved
Norbiros
Norbiros requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@Norbiros Norbiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But mostly code looks nice...

backend/src/models/teams.rs Outdated Show resolved Hide resolved
backend/src/models/teams.rs Outdated Show resolved Hide resolved
backend/src/routes/teams/get_my_team.rs Outdated Show resolved Hide resolved
backend/src/routes/teams/get_my_team.rs Outdated Show resolved Hide resolved
backend/src/routes/teams/view_teams.rs Outdated Show resolved Hide resolved
backend/tests/teams.rs Outdated Show resolved Hide resolved
@Kubaryt Kubaryt force-pushed the feat/teams-endpoints branch from 13d5208 to 1b8e0ca Compare January 20, 2025 11:29
@Kubaryt Kubaryt requested a review from Norbiros January 20, 2025 11:30
Norbiros
Norbiros requested changes Jan 20, 2025
View reviewed changes
backend/src/models/teams.rs Outdated Show resolved Hide resolved
backend/src/routes/teams/my_team.rs Outdated Show resolved Hide resolved
backend/src/routes/teams/view_team.rs Outdated Show resolved Hide resolved
@Kubaryt Kubaryt force-pushed the feat/teams-endpoints branch from 1b8e0ca to e6d9eb3 Compare January 21, 2025 12:25
@Kubaryt Kubaryt requested a review from Norbiros January 21, 2025 13:02
Norbiros
Norbiros approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@Norbiros Norbiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks okay, but I wasn't able to test it after your last changes tho

@goteusz-maszyk goteusz-maszyk dismissed their stale review January 21, 2025 16:24

todo later :)

@Kubaryt Kubaryt merged commit ff98643 into master Jan 22, 2025
2 checks passed
@Kubaryt Kubaryt deleted the feat/teams-endpoints branch January 22, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Norbiros Norbiros Norbiros approved these changes

@goteusz-maszyk goteusz-maszyk goteusz-maszyk approved these changes

@wojpo wojpo Awaiting requested review from wojpo

Assignees

@Kubaryt Kubaryt

Labels
scope: backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Errors always return code 400 [Feat]: Create /teams endpoint
3 participants
@Kubaryt @goteusz-maszyk @Norbiros