Feat: Email confirmation system #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubaryt
force-pushed
the
feat/email-confirmation
branch
from
d72a4e8 to
c6f7164
Compare
Norbiros
requested changes
Feb 6, 2025
| assert!(response.status().is_client_error()); | ||
| } | ||
| // #[actix_web::test] | ||
| // async fn register() { |
There was a problem hiding this comment.
because im not sure if I should create new test for registrations (because current test wont work with email confirmation) or if it will be changed in integration tests issue, and if its the latter then i couldnt merge it because of checks failing
There was a problem hiding this comment.
Integrstions tests will just change how mocking works and a bir test sctructyre. It is not responsiblr for implementing all tesrs
There was a problem hiding this comment.
so i should implement tests for sending confirmation email and confirming it?
# Conflicts: # frontend/openapi/api/openapi.json
… why it doesnt work on gmail
…ed email on /login when parameter redirect_from_confirming is set to true, minor changes and fixes
Kubaryt
force-pushed
the
feat/email-confirmation
branch
from
fefa35a to
dbf7ab6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #130
Features: