Added some more advanced examples #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not know if you agree on there being a need for these more advanced use cases to be included. On my example sheets I have always included them, because especially the chimeric peptides case is quite common for us to find (in TD). My software is one where you can manually annotate a peptide using ProForma and the chimeric case is very handy to know about it that case. If these where to be merged I could remove my own examples and instead link through to these ones.
Sidenote: the link in the final spec document to unusual AAs (section 4.1) is broken. It should link to 7.4.3 instead of 7.5.3 (I put the correct link in the example here as well).