Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Category dashboard with collapsible filters #934
Category dashboard with collapsible filters #934
Changes from 9 commits
d3987bf
b21cc6e
04628eb
07171f7
c312252
706d6f0
fa8c689
e58f7ce
7f837c1
6b24d96
cf7c0e8
bf11a13
ce8df02
bc5af01
b74de3b
728d42f
0d062cc
aea33e1
7aaf182
fea35f0
c16fe45
3987516
5a45a40
d67c907
7820ed5
cd10b24
273d19b
37dbaeb
d861090
3a125ad
062bf5b
f664a28
7fb726e
9a905c3
163cdc3
962851c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the number of origins, I think a primary use case for this data would be to see the proportion of origins that adopt this category relative to all origins that adopt this category.
For example, there are 3.2M WordPress origins and the /categories endpoint says that there are 8.8M origins in the CMS category, so we could show that "market share" value as 36%.
What do you think would be the best way to show the 36% stat? It could be a new column, combined with the # of origins somehow, or replace the # origin column entirely. Alternatively, would you hate a pie chart at the top of the page?
Aside: I suspect the 8.8M number is wrong as it's double-counting origins that use multiple CMSs. WordPress market share should be more like 75% of the CMS category. This is something we'll need to fix in BigQuery.
cc @max-ostapenko
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a primary use case is to see the market share, I'm inclined to say replace the origins with the market share, so the table doesn't become overcrowded with info. The other numbers in the table (% of good CWV etc) feel more important than the absolute number of origins to provide a summary of the category data as well, so if a column has to be hidden to make space for the market share, I think origins is the safest one to remove.
What about just for the top 5/top 10 technologies within a category? I fear anything more than a handful of items will become too busy/hard to read, at which point it's not very useful anymore and the table becomes a better alternative.
If some origins can have multiple CMSes, then adding all the market share percentages can end up being more than 100%, and a pie chart doesn't work anymore? So if that's the case, a different way of highlighting the top techs within a category might be better?
→ Sounds like marketshare might be better for a follow-up issue & PR as well, so we can think through the specifics of it a bit more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM