-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Hindi with translation of core templates #1472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks about line endings but main review is to merge last main
from upstream into this.
Also it's now at the point that it's almost ready to send live, and so tests are getting confused why it's not live, so need to finish off some of the core templates before we accept this. So can we add the following translations to this PR:
- /2019/base.html
- /2019/contributors.html
- /2019/index.html
- /2019/table_of_contents.html
They should be very similar to 2020 versions anyway.
We also need the following to allow this to run:
- /2019/error.html
- change to
src/config/2019.json
to addhi
to thesupported_languages
array - change to
src/config/2020.json
to addhi
to thesupported_languages
array - Addition of Hindi to
src/server/language.py
file around line 34.
And also can you add an entry to both json files with your details, so you can be listed on the site? It's in alphabetical order by first name so around line 878 for 2019.json and line 1129 for 2020.json. You should be in the "translators" team for both.
….com:PraveenPal4232/almanac.httparchive.org into hi-2019
Don't see this one. Can you add that? |
Oh and one more thing. The error.html file have translated error messages. See the French one for example: https://github.com/HTTPArchive/almanac.httparchive.org/blob/main/src/templates/fr/2019/error.html |
Hi @bazzadp, Hope now everything is fine :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's looking great now @PraveenPal4232 . Just one tiny extra change.
I've put a test version here: https://20201110t142408-dot-webalmanac.uk.r.appspot.com/hi/2020/
You can also see what your profile will look like on this!
Could you have a surf around that and make sure you're happy with this? If so let me know and I'll merge this and it will be included in next release in next few days!
Just noticed a small issue in the contributors filter Let me fix this before merge :) Rest is fine |
Thanks, @bazzadp for merging this PR |
Thank you for submitting it! |
Translation of some of these core templates(2020) to Hindi
Also enabled Hindi and added myself to config.
methodology.html
is left in this folder. This is a large file, so I decided to raise a separate PR for that.For issue #1402