Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Hindi with translation of core templates #1472

Merged
merged 14 commits into from
Nov 10, 2020
Merged

Enable Hindi with translation of core templates #1472

merged 14 commits into from
Nov 10, 2020

Conversation

PraveenPal4232
Copy link
Contributor

@PraveenPal4232 PraveenPal4232 commented Nov 10, 2020

Translation of some of these core templates(2020) to Hindi

  • /2019/base.html
  • /2019/contributors.html
  • /2019/index.html
  • /2019/table_of_contents.html
  • /2019/errors.html
  • /2020/base.html
  • /2020/contributors.html
  • /2020/index.html
  • /2020/table_of_contents.html

Also enabled Hindi and added myself to config.

methodology.html is left in this folder. This is a large file, so I decided to raise a separate PR for that.

For issue #1402

@PraveenPal4232 PraveenPal4232 added the translation world wide web label Nov 10, 2020
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks about line endings but main review is to merge last main from upstream into this.

Also it's now at the point that it's almost ready to send live, and so tests are getting confused why it's not live, so need to finish off some of the core templates before we accept this. So can we add the following translations to this PR:

  • /2019/base.html
  • /2019/contributors.html
  • /2019/index.html
  • /2019/table_of_contents.html

They should be very similar to 2020 versions anyway.

We also need the following to allow this to run:

  • /2019/error.html
  • change to src/config/2019.json to add hi to the supported_languages array
  • change to src/config/2020.json to add hi to the supported_languages array
  • Addition of Hindi to src/server/language.py file around line 34.

And also can you add an entry to both json files with your details, so you can be listed on the site? It's in alphabetical order by first name so around line 878 for 2019.json and line 1129 for 2020.json. You should be in the "translators" team for both.

src/templates/hi/2019/base.html Outdated Show resolved Hide resolved
src/templates/hi/2020/base.html Outdated Show resolved Hide resolved
src/templates/hi/2020/contributors.html Outdated Show resolved Hide resolved
src/templates/hi/2020/index.html Outdated Show resolved Hide resolved
src/templates/hi/2020/table_of_contents.html Outdated Show resolved Hide resolved
src/templates/ja/2020/table_of_contents.html Outdated Show resolved Hide resolved
@tunetheweb
Copy link
Member

Addition of Hindi to src/server/language.py file around line 34.

Don't see this one. Can you add that?

@tunetheweb tunetheweb added this to the 2020 Backlog milestone Nov 10, 2020
@tunetheweb
Copy link
Member

Oh and one more thing. The error.html file have translated error messages. See the French one for example: https://github.com/HTTPArchive/almanac.httparchive.org/blob/main/src/templates/fr/2019/error.html

@PraveenPal4232
Copy link
Contributor Author

PraveenPal4232 commented Nov 10, 2020

Hi @bazzadp, Hope now everything is fine :)
Please let me know...

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's looking great now @PraveenPal4232 . Just one tiny extra change.

I've put a test version here: https://20201110t142408-dot-webalmanac.uk.r.appspot.com/hi/2020/

You can also see what your profile will look like on this!

Could you have a surf around that and make sure you're happy with this? If so let me know and I'll merge this and it will be included in next release in next few days!

src/templates/hi/2019/error.html Outdated Show resolved Hide resolved
@PraveenPal4232
Copy link
Contributor Author

That's looking great now @PraveenPal4232 . Just one tiny extra change.

I've put a test version here: https://20201110t142408-dot-webalmanac.uk.r.appspot.com/hi/2020/

You can also see what your profile will look like on this!

Could you have a surf around that and make sure you're happy with this? If so let me know and I'll merge this and it will be included in next release in next few days!

Just noticed a small issue in the contributors filter
Now : टीम द्वारा फ़िल्टर करें: 15 में से 98 योगदानकर्ता।
Should be : टीम द्वारा फ़िल्टर करें: 98 में से 15 योगदानकर्ता।

Let me fix this before merge :) Rest is fine

@tunetheweb
Copy link
Member

OK. Let me know when good to go.

On a related note, I'm about to add a Chapter Links title:

Chapter Links Screenshot

Could you let me know what I should use for "Chapter Links" in Hindi? Google Translate suggests अध्याय लिंक - is that accurate?

@PraveenPal4232
Copy link
Contributor Author

Chapter Links

OK. Let me know when good to go.

On a related note, I'm about to add a Chapter Links title:

Chapter Links Screenshot

Could you let me know what I should use for "Chapter Links" in Hindi? Google Translate suggests अध्याय लिंक - is that accurate?

Yes It is "अध्याय लिंक"

@tunetheweb
Copy link
Member

Here's what that looks like now:

Hindi contributors

@PraveenPal4232
Copy link
Contributor Author

PraveenPal4232 commented Nov 10, 2020

Here's what that looks like now:

Hindi contributors

Yes! I checked it's perfect :) Also fixed the contributors filter.
Let's wait for checks, then we are good to go :)

@tunetheweb tunetheweb merged commit 17601be into HTTPArchive:main Nov 10, 2020
@PraveenPal4232
Copy link
Contributor Author

Thanks, @bazzadp for merging this PR

@tunetheweb
Copy link
Member

Thank you for submitting it!

@tunetheweb tunetheweb changed the title Translation of some core templates(2020) to Hindi Translation of the core templates to Hindi Nov 10, 2020
@tunetheweb tunetheweb changed the title Translation of the core templates to Hindi Translation of the core templates and launch of Hindi Nov 10, 2020
@tunetheweb tunetheweb changed the title Translation of the core templates and launch of Hindi Enable Hindi with translation of core templates Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation world wide web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants