Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue branch 340 #2199

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Issue branch 340 #2199

wants to merge 2 commits into from

Conversation

gparlakov
Copy link

Hello, I want to tackle the Controller names magic strings issue.

I found 3 use cases:

  1. Need the name from the context of the Controller itself
  2. Need the name for another Controller from the context of a Controller
  3. Need the name for a Controller from a general context

Case 3 is covered by the ControllerNames.NameOf and cases 1. and 2. are using it and are just convenience methods to use from the context of a controller

Georgi Parlakov added 2 commits January 6, 2018 21:02
…ix. Also add a couple of convenience extension methods that use it.
@MisterJames
Copy link
Contributor

Hrm....I want to discuss this with a few regulars on the team.

IMO, if we're going to try to tackle the magic names on controllers, why don't we just instead drop the Controller suffix? We inherit from Controller anyway, and our controllers all live in a /Controllers folder. Maybe we don't need the extra chars?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants