Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused 'ctxMarker' variables #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tschwinge
Copy link

On powerpc64le-unknown-linux-gnu, 'g++ (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0', a
plain 'cmake && make' build fails:

[ 36%] Building CXX object libHSAIL/CMakeFiles/hsail.dir/HSAILScannerRules.cpp.o
In file included from [...]/libHSAIL/HSAILScannerRules.cpp:46:0:
[...]/libHSAIL/generated/HSAILScannerRules_gen_re2c.hpp: In member function 'HSAIL_ASM::ETokens HSAIL_ASM::Scanner::scanModifier(HSAIL_ASM::EScanContext, HSAIL_ASM::Scanner::Token&)':
[...]/libHSAIL/generated/HSAILScannerRules_gen_re2c.hpp:271:17: error: unused variable 'ctxMarker' [-Werror=unused-variable]
     const char *ctxMarker = NULL;
                 ^~~~~~~~~
[...]/libHSAIL/generated/HSAILScannerRules_gen_re2c.hpp: In member function 'HSAIL_ASM::ETokens HSAIL_ASM::Scanner::scanDefault(HSAIL_ASM::EScanContext, HSAIL_ASM::Scanner::Token&)':
[...]/libHSAIL/generated/HSAILScannerRules_gen_re2c.hpp:14065:17: error: unused variable 'ctxMarker' [-Werror=unused-variable]
     const char *ctxMarker = NULL;
                 ^~~~~~~~~
cc1plus: all warnings being treated as errors
libHSAIL/CMakeFiles/hsail.dir/build.make:346: recipe for target 'libHSAIL/CMakeFiles/hsail.dir/HSAILScannerRules.cpp.o' failed
make[2]: *** [libHSAIL/CMakeFiles/hsail.dir/HSAILScannerRules.cpp.o] Error 1
CMakeFiles/Makefile2:87: recipe for target 'libHSAIL/CMakeFiles/hsail.dir/all' failed
make[1]: *** [libHSAIL/CMakeFiles/hsail.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2

In the generated file 'libHSAIL/generated/HSAILScannerRules_gen_re2c.hpp', the
'libHSAIL/HSAILScannerRules.re2c' change only removes the two 'ctxMarker'
variables, and doesn't cause any other changes, so presumably they're unused,
and can be removed, together with 're2c:define:YYCTXMARKER'.

On powerpc64le-unknown-linux-gnu, 'g++ (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0', a
plain 'cmake && make' build fails:

    [ 36%] Building CXX object libHSAIL/CMakeFiles/hsail.dir/HSAILScannerRules.cpp.o
    In file included from [...]/libHSAIL/HSAILScannerRules.cpp:46:0:
    [...]/libHSAIL/generated/HSAILScannerRules_gen_re2c.hpp: In member function 'HSAIL_ASM::ETokens HSAIL_ASM::Scanner::scanModifier(HSAIL_ASM::EScanContext, HSAIL_ASM::Scanner::Token&)':
    [...]/libHSAIL/generated/HSAILScannerRules_gen_re2c.hpp:271:17: error: unused variable 'ctxMarker' [-Werror=unused-variable]
         const char *ctxMarker = NULL;
                     ^~~~~~~~~
    [...]/libHSAIL/generated/HSAILScannerRules_gen_re2c.hpp: In member function 'HSAIL_ASM::ETokens HSAIL_ASM::Scanner::scanDefault(HSAIL_ASM::EScanContext, HSAIL_ASM::Scanner::Token&)':
    [...]/libHSAIL/generated/HSAILScannerRules_gen_re2c.hpp:14065:17: error: unused variable 'ctxMarker' [-Werror=unused-variable]
         const char *ctxMarker = NULL;
                     ^~~~~~~~~
    cc1plus: all warnings being treated as errors
    libHSAIL/CMakeFiles/hsail.dir/build.make:346: recipe for target 'libHSAIL/CMakeFiles/hsail.dir/HSAILScannerRules.cpp.o' failed
    make[2]: *** [libHSAIL/CMakeFiles/hsail.dir/HSAILScannerRules.cpp.o] Error 1
    CMakeFiles/Makefile2:87: recipe for target 'libHSAIL/CMakeFiles/hsail.dir/all' failed
    make[1]: *** [libHSAIL/CMakeFiles/hsail.dir/all] Error 2
    Makefile:140: recipe for target 'all' failed
    make: *** [all] Error 2

In the generated file 'libHSAIL/generated/HSAILScannerRules_gen_re2c.hpp', the
'libHSAIL/HSAILScannerRules.re2c' change only removes the two 'ctxMarker'
variables, and doesn't cause any other changes, so presumably they're unused,
and can be removed, together with 're2c:define:YYCTXMARKER'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant