Make Thm.SPEC use lazy_beta_conv instead of beta_conv #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
someplaceguy
force-pushed
the
u/spec-fix
branch
3 times, most recently
from
c2d27da
to
0bc0778
Compare
The former, unlike the latter, avoids traversing the entire term, which can take exponentially long in certain degenerate conditions observed while replaying certain Z3 proof certificates. Unfortunately, this only fixes the issue for the standard kernel. The experimental kernel does not seem to be amenable to such a straightforward fix, as it does not seem to support closures in the underlying term representation. Partially fixes HOL-Theorem-Prover#1300
someplaceguy
force-pushed
the
u/spec-fix
branch
from
0bc0778
to
c1a43f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former, unlike the latter, avoids traversing the entire term, which can take exponentially long in certain degenerate conditions observed while replaying certain Z3 proof certificates.
Unfortunately, this only fixes the issue for the standard kernel. The experimental kernel does not seem to be amenable to such a straightforward fix, as it does not seem to support closures in the underlying term representation.
Partially fixes #1300
Note: I'm not completely certain that it is safe to perform this change, as I do not have a complete understanding of the HOL kernel design or implementation.
Also, I've only done minimal testing by performing a standard build and observing that it completes successfully. I'd be happy to perform more extensive testing if you could provide pointers as to how to perform such testing.
Thanks!