More arguments for newtypeTools.rich_new_type #1215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The (undocumented) tool
newtypeTools.rich_new_type
currently lacks the ability to specify the newly created function constants for converting between the abstraction and representation types (ABS and REP). The current workaround is to do overloading after calling it, e.g., inwellorderScript.sml
:In this PR, per our offline discussions, I have modified the signature of
rich_new_type
to allow providing ABS and REP constant names. The new signature is the following:All existing uses in core theories and examples are updated with the extra ABS and REP parameters (NOTE: SML doesn't support optional record slot values).
NOTE: in
wellorderScript.sml
, although the two constantswellorder_ABS
andwellorder_REP
were overloaded, they are still used in many places. I have updated them all.--Chun