Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed temporal_deep tests #1180

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

binghe
Copy link
Member

@binghe binghe commented Jan 16, 2024

Hi,

HOL built by Moscow ML is still working, including the HolBdd examples and temporal_deep examples with a SMV checker. When HOL4_SMV_EXECUTABLE is set to NuSMV, nuXmv or NuRV (all from FBK), the self tests in examples/temporal_deep/src/model_check/selftest.sml also still work but there are two unmatched parentheses by last commit (in 2018).

Chun

@binghe
Copy link
Member Author

binghe commented Jan 16, 2024

In #1179, the latest updates to Docker image binghelisp/hol-dev:latest now contains an installation of NuRV [1], which is compatible with the original SMV checker. When pulling this image and building HOL with Moscow ML, all tests under examples/temporal_deep/src/model_check will work, with help of the SMV checker on LTL formulas.

[1] https://es-static.fbk.eu/tools/nurv/

@mn200
Copy link
Member

mn200 commented Jan 17, 2024

Thanks for this!

@mn200 mn200 merged commit 4103c90 into HOL-Theorem-Prover:develop Jan 17, 2024
2 checks passed
@binghe binghe deleted the mosml_examples branch January 31, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants