Automation for defining from/to functions for cv_compute's cv type #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myreen
commented
Aug 25, 2023
| $(HOL_LNSIGOBJ) | ||
| endif | ||
|
|
||
| selftest.exe: selftest.uo |
There was a problem hiding this comment.
@mn200 should this line have more deps?
There was a problem hiding this comment.
As long as selftest.sml clearly depends (via on open fooTheory type line) on what's needed, this should be fine.
myreen
changed the title
mn200
approved these changes
Aug 28, 2023
| $(HOL_LNSIGOBJ) | ||
| endif | ||
|
|
||
| selftest.exe: selftest.uo |
There was a problem hiding this comment.
As long as selftest.sml clearly depends (via on open fooTheory type line) on what's needed, this should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent cv_compute feature in the HOL4 kernel allows for fast computation, but requires all input to cv_compute to be phrased in terms of the simple Lisp-like
cvtype.This PR adds automation for defining mappings between the
cvtype and user-defined datatypes. For each run of the new automation, the tool proves that applying the mapping into thecvtype and then the mapping out of thecvtype is the same as applying the identity function.Future PRs will provide further automation to ease use of the new cv_compute feature.