-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fermat #1139
Fermat #1139
Conversation
…cate theorems now in standard libraries, make the set of divisors positive, update windmill for a triple, and improve documentation.
…t FILTER is a sublist, and a sublist preserves the ordering of elements.
… a better upper bound for the number of windmills.
…shapes rather than windmills.
…ion algorithm, to find the two squares for a tik prime.
Take them and form a pair (a,b). | ||
*) | ||
Theorem fermat_two_squares_by_corners: | ||
!p. tik p /\ prime p ==> ?(a, b). p = a ** 2 + b ** 2 /\ a < b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless there's strong reason to, please don't use paired existentials, like ?(a,b)....
Instead, just have the existentially quantified variables listed: ?a b. ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New commit uses simple existentially quantified variables. Should I worry about the failure of [d64379b]?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Now I learn how to read the log, and fixed the problem. Hope this is the only one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This time it is the standard kernel, but I have used rename1 to ensure proper variable rename. Log seems not to fail in fermat/ folder. Any suggestion about the exact issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all your help, much appreciated.
…ares using corner pieces.
Failure (visible through link) is:
This was in the experimental kernel where variable names chosen by the kernel can be different. |
Still seem to be an issue? |
That more recent error is not yours; it's a common repeated error that that file throws up non-deterministically. Thanks for your work! |
Update algebra library, incorporate an improved algorithm for Fermat's Two Squares Theorem.