Promote HOL-Light's pairwise
to pred_setTheory replacing the old one
#1135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
currently there are two versions of
pairwise
describing pairwise (binary) relation of set elements. The existing one inpred_setTheory
allow pairs of two identical elements:While the version in
topologyTheory
was from HOL-Light, requiring pairs of distinct elements:The version in
pred_setTheory
is currently not used by any other proofs in the core theory (or basic examples, I didn't test all examples) and there are only two supporting simple lemmas. On the other hand, HOL-Light'spairwise
was originally ported as part ofreal_topologyTheory
and is used in various places. In particular, the following definition ofdisjoint
(currently inutil_probTheory
) can be improved by re-defining it as an overload topairwise DISJOINT
:For better compatibility with HOL-Light derived theories, I propose we merge the two
pairwise
definitions and use HOL-Light's version as the referenced version in core library. This looks like we added the distinct requirements into the existing definition and the existing two lemmas either remains or have slightly changed. The abovedisjoint_def
and supporting theorems are refined and moved fromutil_prob
totopology
.For other irrelevant small changes, there's a leftover in
src/rational
for the name changes of ring-related stuff. I also renamed the newly added theorempermutes_bijn
topermutes_alt_bijns
, mostly becausebijn
is not a constant butbijns
is. The theorypermutes
is added into the OT theoryhol-set
.Regards,
Chun Tian