Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is the
extreal_baseTheory
(insrc/real
) we discussed in the comments of #1126. It depends oniterateTheory
with the only the basic extreal operators (+, -, ~, *, /, pow, sqrt, abs, max and min) and related theorems. I didn't moveEXTREAL_SUM_IMAGE
andEXTREAL_PROD_IMAGE
but this is indeed possible (in the future).The code changes didn't break anything which depends on the existing
extrealTheory
, which still exports all theorems moved toextreal_baseTheory
. To implement this behavior, there's a long list of names at the end ofextrealScript.sml
. I think we can keep this list for a while, until most of the user code start to openextreal_baseTheory
.All theorems in the new
extreal_baseTheory
are changed to modern syntax. Theorems are re-grouped and re-ordered by their key operators. I slightly modified the statements of a few rewriting rules (nothing should be broken), some proofs are simplified. Finally, the OpenTheory related definitions are also updated (but I haven't tested the full build yet, which requires long time waiting.)Now the remaining
extrealTheory
contains mostly advanced part (sup, inf, sequence limits, and other set-theoretic staff). I believe the parallelism of HOL builds is also slightly improved.Regards,
Chun Tian
P.S. in
util_probTheory
, the dependencies are cleaned up. A theoremIN_o
(~=pred_setTheory.IN_PREIMAGE
) is deleted because it's not used in the rest of probability scripts, and this theorem has another copy inexamples/miller
for its local use.