-
Notifications
You must be signed in to change notification settings - Fork 143
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix minor bug caused by lg constant's move from util_prob to transc
Document same in release notes.
- Loading branch information
Showing
2 changed files
with
4 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ee6798
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about renaming
lg
(in transc) tolog2
? I think in many text bookslg
means the 10-based one, but I preferlog10
to avoid any potential ambiguity.2ee6798
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
lg
is already in heavy use elsewhere I’m happy to keep the name. It was, as you can see, a very minor adjustment.2ee6798
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
lg
was defined by Joe Hurd and is used somewhere in his example scripts. I personal think overloading it tologr 2
is the best option but let’s keep the current situation for now. This issue is too minor to be concerned.2ee6798
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just occasionally found in a book called «Concrete Mathematics» (by Knuth, et al.), in which
lg x
denotes binary logarithm andlog x
denotescommon logarithm
(i.e. 10-based). Thus the existing choice intranscTheory
is actually good. One day we can even addlog
in transcTheory (either as definition or overload) for common logarithm.2ee6798
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find!