chore: run the ruff format and pyupgrade tools
#633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjosw
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Hey @agriyakhetarpal, looks good to me and should certainly help with readability of the code, thanks!
agriyakhetarpal
added a commit
that referenced
this pull request
Aug 30, 2024
Continuing from #633, this PR adds support for the `pre-commit` via its configuration file, which works with https://pre-commit.ci. - I have suppressed all failing rules to get `pre-commit` passing in 68e3dda, so that we can fix them all later. - At most, the style changes in this PR are the imports that have been tidied up and sorted using the `ruff check . --select I --fix && ruff format .` command. - The pre-commit config configuration file was added Additionally, to automatically enable `pre-commit` as a Git hook locally, type: ```bash pip install pre-commit pre-commit install ``` and subsequently, it would not allow creating commits that fail the style rules we have set in `pyproject.toml` or those in `.pre-commit-config.yaml`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I have performed the following changes across the codebase:
ruff formatacross all our files to automatically clean them up wherever possible, andpyupgrade(i.e., thepyupgrade --py38-pluscommand) on all files to make our code adhere to Python 3.8+ syntax as applicable.A pre-commit configuration has yet to be established, and the pre-commit.ci app has now been requested for the repository (cc: @j-towns, who can approve it for us as the admin). The app will work once it gets approved. The pre-commit configuration with some popular pre-commit hooks can be added either here or as a separate PR with more linting changes.
Hopefully, this will help with some of your previous remarks about the tidiness of the code, @fjosw 😄