Removing Contract.Assume

HHobeck · Feb 19, 2024 · 4664ed9 · 4664ed9
1 parent 8119ea1
commit 4664ed9
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 14 deletions.
diff --git a/src/GitVersion.Core/Git/ReferenceName.cs b/src/GitVersion.Core/Git/ReferenceName.cs
@@ -1,5 +1,4 @@
 using System.Diagnostics.CodeAnalysis;
-using System.Diagnostics.Contracts;
 using System.Text.RegularExpressions;
 using GitVersion.Extensions;
 using GitVersion.Helpers;
@@ -85,8 +84,6 @@ public bool TryGetSemanticVersion([NotNullWhen(true)] out (SemanticVersion Value
     {
         result = default;
 
-        Contract.Assume(versionPatternRegex.ToString().StartsWith('^'));
-
         int length = 0;
         foreach (var branchPart in WithoutOrigin.Split(GetBranchSeparator()))
         {

diff --git a/...Version.Core/VersionCalculation/VersionCalculators/ContinuousDeliveryVersionCalculator.cs b/...Version.Core/VersionCalculation/VersionCalculators/ContinuousDeliveryVersionCalculator.cs
@@ -1,4 +1,3 @@
-using System.Diagnostics.Contracts;
 using GitVersion.Common;
 using GitVersion.Logging;
 
@@ -23,20 +22,17 @@ public SemanticVersion Calculate(SemanticVersion semanticVersion, ICommit? baseV
 
     private SemanticVersion CalculateInternal(SemanticVersion semanticVersion, ICommit? baseVersionSource)
     {
-        Contract.Assume(semanticVersion.PreReleaseTag.Number.HasValue);
-
         var buildMetaData = CreateVersionBuildMetaData(baseVersionSource);
-        Contract.Assume(buildMetaData.CommitsSinceTag.HasValue);
 
         return new SemanticVersion(semanticVersion)
         {
             PreReleaseTag = new SemanticVersionPreReleaseTag(semanticVersion.PreReleaseTag)
             {
-                Number = semanticVersion.PreReleaseTag.Number.Value + buildMetaData.CommitsSinceTag - 1
+                Number = semanticVersion.PreReleaseTag.Number!.Value + buildMetaData.CommitsSinceTag - 1
             },
             BuildMetaData = new SemanticVersionBuildMetaData(buildMetaData)
             {
-                CommitsSinceVersionSource = buildMetaData.CommitsSinceTag.Value,
+                CommitsSinceVersionSource = buildMetaData.CommitsSinceTag!.Value,
                 CommitsSinceTag = null
             }
         };

diff --git a/...rsion.Core/VersionCalculation/VersionCalculators/ContinuousDeploymentVersionCalculator.cs b/...rsion.Core/VersionCalculation/VersionCalculators/ContinuousDeploymentVersionCalculator.cs
@@ -1,4 +1,3 @@
-using System.Diagnostics.Contracts;
 using GitVersion.Common;
 using GitVersion.Logging;
 
@@ -18,14 +17,13 @@ public SemanticVersion Calculate(SemanticVersion semanticVersion, ICommit? baseV
     private SemanticVersion CalculateInternal(SemanticVersion semanticVersion, ICommit? baseVersionSource)
     {
         var buildMetaData = CreateVersionBuildMetaData(baseVersionSource);
-        Contract.Assume(buildMetaData.CommitsSinceTag.HasValue);
 
         return new SemanticVersion(semanticVersion)
         {
             PreReleaseTag = SemanticVersionPreReleaseTag.Empty,
             BuildMetaData = new SemanticVersionBuildMetaData(buildMetaData)
             {
-                CommitsSinceVersionSource = buildMetaData.CommitsSinceTag.Value,
+                CommitsSinceVersionSource = buildMetaData.CommitsSinceTag!.Value,
                 CommitsSinceTag = null
             }
         };

diff --git a/...itVersion.Core/VersionCalculation/VersionCalculators/ManualDeploymentVersionCalculator.cs b/...itVersion.Core/VersionCalculation/VersionCalculators/ManualDeploymentVersionCalculator.cs
@@ -1,4 +1,3 @@
-using System.Diagnostics.Contracts;
 using GitVersion.Common;
 using GitVersion.Logging;
 
@@ -18,7 +17,6 @@ public SemanticVersion Calculate(SemanticVersion semanticVersion, ICommit? baseV
     private SemanticVersion CalculateInternal(SemanticVersion semanticVersion, ICommit? baseVersionSource)
     {
         var buildMetaData = CreateVersionBuildMetaData(baseVersionSource);
-        Contract.Assume(buildMetaData.CommitsSinceTag.HasValue);
 
         return new SemanticVersion(semanticVersion)
         {